Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17204 )

Change subject: KUDU-1926: disable TLS/SSL session renegotiation
......................................................................


Patch Set 2: Verified+1

> There is funny crash with SIGSEGV if running under TSAN: I'll need
 > to clarify on that.
 >
 >
 > home/jenkins-slave/workspace/kudu-master/1/src/kudu/tools/kudu-tool-test.cc:315
 > Failed
 > Bad status: Runtime error: /tmp/dist-test-task4slHfE/build/tsan/bin/kudu:
 > process exited on signal 11 (core dumped)
 > Google Test trace:
 > /home/jenkins-slave/workspace/kudu-master/1/src/kudu/tools/kudu-tool-test.cc:314:
 > W0319 06:43:49.983834 27011 flags.cc:411] Enabled unsafe flag:
 > --openssl_security_level_override=0
 > W0319 06:43:49.984328 27011 flags.cc:411] Enabled unsafe flag:
 > --never_fsync=true
 > W0319 06:43:50.808722 27011 thread.cc:616] rpc reactor (reactor)
 > Time spent creating pthread: real 0.775s     user 0.356s     sys 0.418s
 > W0319 06:43:50.809056 27011 thread.cc:582] rpc reactor (reactor)
 > Time spent starting thread: real 0.775s      user 0.356s     sys 0.418s
 > *** Aborted at 1616136230 (unix time) try "date -d @1616136230" if
 > you are using GNU date ***
 > PC: @     0x7fd2b07fa26a __GI___pthread_rwlock_unlock
 > *** SIGSEGV (@0x18) received by PID 27011 (TID 0x7fd2a1883700) from
 > PID 24; stack trace: ***
 > @           0x4f8b10 __tsan::CallUserSignalHandler()
 > @           0x4fb027 rtl_sigaction()
 > @     0x7fd2b07ff980 (unknown)
 > @     0x7fd2b07fa26a __GI___pthread_rwlock_unlock
 > @           0x4ff2b2 pthread_rwlock_unlock
 > @     0x7fd2aed4e8a9 CRYPTO_THREAD_unlock
 > @     0x7fd2aece481f CRYPTO_free_ex_data
 > @     0x7fd2aed183b2 RSA_free
 > @     0x7fd2aecdfc9b (unknown)
 > @     0x7fd2aece0899 EVP_PKEY_free
 > @     0x7fd2aed6965c (unknown)
 > @     0x7fd2aec0fac7 (unknown)
 > @     0x7fd2aec0fc30 (unknown)
 > @     0x7fd2aec0fa26 (unknown)
 > @     0x7fd2aec0fc30 (unknown)
 > @     0x7fd2aec0fa26 (unknown)
 > @     0x7fd2aec0fb55 ASN1_item_free
 > @     0x7fd2aed5d069 X509_OBJECT_free
 > @     0x7fd2aed4afc0 OPENSSL_sk_pop_free
 > @     0x7fd2aed5d5ac X509_STORE_free
 > @     0x7fd2ae919af4 SSL_CTX_free
 > @     0x7fd2af657c88 
 > _ZNSt3__18__invokeIRPFvP10ssl_ctx_stEJS2_EEEDTclclsr3std3__1E7forwardIT_Efp_Espclsr3std3__1E7forwardIT0_Efp0_EEEOS6_DpOS7_
 > @     0x7fd2af657bf4 
 > _ZNSt3__128__invoke_void_return_wrapperIvE6__callIJRPFvP10ssl_ctx_stES4_EEEvDpOT_
 > @     0x7fd2af657ba4 std::__1::__function::__alloc_func<>::operator()()
 > @     0x7fd2af6567dd std::__1::__function::__func<>::operator()()
 > @     0x7fd2afd074b7 std::__1::__function::__value_func<>::operator()()
 > @     0x7fd2afd073ec std::__1::function<>::operator()()
 > @     0x7fd2afd072fe std::__1::unique_ptr<>::reset()
 > @     0x7fd2afd06dbc std::__1::unique_ptr<>::~unique_ptr()
 > @     0x7fd2afd06d4a kudu::security::TlsContext::~TlsContext()
 > @     0x7fd2afd06c9f std::__1::default_delete<>::operator()()
 > @     0x7fd2afd06c0e std::__1::unique_ptr<>::reset()
 > /home/jenkins-slave/workspace/kudu-master/1/src/kudu/tools/kudu-tool-test.cc:313:
 > (int32 key=1) (int32 key=2) (int32 key=3) (int32 key=4) (int32
 > key=5) T ebd1313dc9ed4e9393c8c966988f7681 scanned count 5 cost
 > 0.0375527 seconds Total count 5 cost 0.0400349 seconds

I could not reproduce the flake.

 > There is funny crash with SIGSEGV if running under TSAN: I'll need
 > to clarify on that.
 > 
 >
 > home/jenkins-slave/workspace/kudu-master/1/src/kudu/tools/kudu-tool-test.cc:315
 > Failed
 > Bad status: Runtime error: /tmp/dist-test-task4slHfE/build/tsan/bin/kudu:
 > process exited on signal 11 (core dumped)
 > Google Test trace:
 > /home/jenkins-slave/workspace/kudu-master/1/src/kudu/tools/kudu-tool-test.cc:314:
 > W0319 06:43:49.983834 27011 flags.cc:411] Enabled unsafe flag:
 > --openssl_security_level_override=0
 > W0319 06:43:49.984328 27011 flags.cc:411] Enabled unsafe flag:
 > --never_fsync=true
 > W0319 06:43:50.808722 27011 thread.cc:616] rpc reactor (reactor)
 > Time spent creating pthread: real 0.775s     user 0.356s     sys 0.418s
 > W0319 06:43:50.809056 27011 thread.cc:582] rpc reactor (reactor)
 > Time spent starting thread: real 0.775s      user 0.356s     sys 0.418s
 > *** Aborted at 1616136230 (unix time) try "date -d @1616136230" if
 > you are using GNU date ***
 > PC: @     0x7fd2b07fa26a __GI___pthread_rwlock_unlock
 > *** SIGSEGV (@0x18) received by PID 27011 (TID 0x7fd2a1883700) from
 > PID 24; stack trace: ***
 > @           0x4f8b10 __tsan::CallUserSignalHandler()
 > @           0x4fb027 rtl_sigaction()
 > @     0x7fd2b07ff980 (unknown)
 > @     0x7fd2b07fa26a __GI___pthread_rwlock_unlock
 > @           0x4ff2b2 pthread_rwlock_unlock
 > @     0x7fd2aed4e8a9 CRYPTO_THREAD_unlock
 > @     0x7fd2aece481f CRYPTO_free_ex_data
 > @     0x7fd2aed183b2 RSA_free
 > @     0x7fd2aecdfc9b (unknown)
 > @     0x7fd2aece0899 EVP_PKEY_free
 > @     0x7fd2aed6965c (unknown)
 > @     0x7fd2aec0fac7 (unknown)
 > @     0x7fd2aec0fc30 (unknown)
 > @     0x7fd2aec0fa26 (unknown)
 > @     0x7fd2aec0fc30 (unknown)
 > @     0x7fd2aec0fa26 (unknown)
 > @     0x7fd2aec0fb55 ASN1_item_free
 > @     0x7fd2aed5d069 X509_OBJECT_free
 > @     0x7fd2aed4afc0 OPENSSL_sk_pop_free
 > @     0x7fd2aed5d5ac X509_STORE_free
 > @     0x7fd2ae919af4 SSL_CTX_free
 > @     0x7fd2af657c88 
 > _ZNSt3__18__invokeIRPFvP10ssl_ctx_stEJS2_EEEDTclclsr3std3__1E7forwardIT_Efp_Espclsr3std3__1E7forwardIT0_Efp0_EEEOS6_DpOS7_
 > @     0x7fd2af657bf4 
 > _ZNSt3__128__invoke_void_return_wrapperIvE6__callIJRPFvP10ssl_ctx_stES4_EEEvDpOT_
 > @     0x7fd2af657ba4 std::__1::__function::__alloc_func<>::operator()()
 > @     0x7fd2af6567dd std::__1::__function::__func<>::operator()()
 > @     0x7fd2afd074b7 std::__1::__function::__value_func<>::operator()()
 > @     0x7fd2afd073ec std::__1::function<>::operator()()
 > @     0x7fd2afd072fe std::__1::unique_ptr<>::reset()
 > @     0x7fd2afd06dbc std::__1::unique_ptr<>::~unique_ptr()
 > @     0x7fd2afd06d4a kudu::security::TlsContext::~TlsContext()
 > @     0x7fd2afd06c9f std::__1::default_delete<>::operator()()
 > @     0x7fd2afd06c0e std::__1::unique_ptr<>::reset()
 > /home/jenkins-slave/workspace/kudu-master/1/src/kudu/tools/kudu-tool-test.cc:313:
 > (int32 key=1) (int32 key=2) (int32 key=3) (int32 key=4) (int32
 > key=5) T ebd1313dc9ed4e9393c8c966988f7681 scanned count 5 cost
 > 0.0375527 seconds Total count 5 cost 0.0400349 seconds

I could not reproduce the flake.  And I'm quite sure it's not related to the 
essence of this patch.


--
To view, visit http://gerrit.cloudera.org:8080/17204
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib585dcfc2c3f641268ceded19e0ea5c551d97ae1
Gerrit-Change-Number: 17204
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 20 Mar 2021 01:14:09 +0000
Gerrit-HasComments: No

Reply via email to