Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17022 )
Change subject: KUDU-2612: allow aborting after beginning to commit ...................................................................... Patch Set 9: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/17022/9/src/kudu/integration-tests/txn_commit-itest.cc File src/kudu/integration-tests/txn_commit-itest.cc: http://gerrit.cloudera.org:8080/#/c/17022/9/src/kudu/integration-tests/txn_commit-itest.cc@776 PS9, Line 776: ASSERT_TRUE(txn.state == tablet::kAborted || txn.state == tablet::kCommitted) Just wanted to make sure we are on the same page here: is this stable enough even without ASSERT_EVENTUALLY? I'd expect that finalizing the rollback of a transaction takes some time, and in case of TSAN builds it might be some flakiness, no? -- To view, visit http://gerrit.cloudera.org:8080/17022 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1b6596df2db5601f7e17e528ad6dc68057b67f8 Gerrit-Change-Number: 17022 Gerrit-PatchSet: 9 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 23 Mar 2021 06:51:43 +0000 Gerrit-HasComments: Yes
