Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17097 )
Change subject: KUDU-2612: add ScopedPartitionLock ...................................................................... Patch Set 14: (5 comments) http://gerrit.cloudera.org:8080/#/c/17097/13/src/kudu/tablet/lock_manager-test.cc File src/kudu/tablet/lock_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/17097/13/src/kudu/tablet/lock_manager-test.cc@267 PS13, Line 267: } else { > nit: does it make sense to add an ASSERT to make sure the lock is either ac Done http://gerrit.cloudera.org:8080/#/c/17097/13/src/kudu/tablet/lock_manager-test.cc@270 PS13, Line 270: } > Very nice scenario -- thank you for adding this one. Thanks! http://gerrit.cloudera.org:8080/#/c/17097/13/src/kudu/tablet/lock_manager.cc File src/kudu/tablet/lock_manager.cc: http://gerrit.cloudera.org:8080/#/c/17097/13/src/kudu/tablet/lock_manager.cc@485 PS13, Line 485: bool has_timeout = timeout.Initialized(); > nit: is it possible to move this under the 'if (timeout.Initialized())' cas Done http://gerrit.cloudera.org:8080/#/c/17097/13/src/kudu/tablet/lock_manager.cc@521 PS13, Line 521: : PartitionLockState* LockManager::WaitUntilAcquiredPartitionLo > nit: combine these two lines into a single one? Done http://gerrit.cloudera.org:8080/#/c/17097/13/src/kudu/tablet/lock_manager.cc@522 PS13, Line 522: edPartition > nit: maybe, change the signature of this method to make this last parameter Done -- To view, visit http://gerrit.cloudera.org:8080/17097 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I158115739ce3e7cfb77bbcb854e834336c1256b1 Gerrit-Change-Number: 17097 Gerrit-PatchSet: 14 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 23 Mar 2021 07:43:13 +0000 Gerrit-HasComments: Yes
