Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17220 )
Change subject: [master] Script to automate adding a master ...................................................................... Patch Set 1: > Patch Set 1: > > > Patch Set 1: Verified-1 > > > > Build Failed > > > > http://jenkins.kudu.apache.org/job/kudu-gerrit/23535/ : FAILURE > > Looks like the build machines don't have "bc" which is used to compare > floating point numbers in bash. I'll look for alternative or some other > technique. This is getting to be a pretty hefty script. Before trying to jump through more hoops to get this working, have you given much thought to folding these calls into the tool as some `kudu master orchestrate_add_master` or even into the `add_master` tool directly? I'm fine with this being a bash script, but I want to be sure bash is actually the right tool for the job, especially considering we have a means to bake a lot of this into tooling fairly easily -- heck, you've already done a lot of this in dynamic_multi_master-test! And from a maintainability perspective, big bash scripts like seem much more palatable when not written in bash :) -- To view, visit http://gerrit.cloudera.org:8080/17220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc9dad73be625ff30070c522626bd79f1f1aa90c Gerrit-Change-Number: 17220 Gerrit-PatchSet: 1 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 24 Mar 2021 05:38:47 +0000 Gerrit-HasComments: No
