Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17236 )
Change subject: [consensus] small cleanup on consensus::Peer ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/17236/1/src/kudu/consensus/consensus_peers.cc File src/kudu/consensus/consensus_peers.cc: http://gerrit.cloudera.org:8080/#/c/17236/1/src/kudu/consensus/consensus_peers.cc@276 PS1, Line 276: if (!has_sent_first_request_) { : // Set the 'immutable' fields in the request only once upon first request. : request_.set_tablet_id(tablet_id_); : request_.set_caller_uuid(leader_uuid_); : request_.set_dest_uuid(peer_pb_.permanent_uuid()); : has_sent_first_request_ = true; : } Just for my own understanding, it doesn't really matter when this gets set as long as it's set before sending (or logging, per below) 'request_', right? And in that regard, we're just deferring the setting of it as far as we can? -- To view, visit http://gerrit.cloudera.org:8080/17236 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefce6791d12fbd126ee30104d1005209ad3de3ff Gerrit-Change-Number: 17236 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 29 Mar 2021 23:33:14 +0000 Gerrit-HasComments: Yes
