Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17180 )
Change subject: [master] Remove FLAGS_master_consensus_allow_status_msg_for_failed_peer ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/17180/2/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/17180/2/src/kudu/master/master_service.cc@98 PS2, Line 98: false > Are we comfortable enough with this flag to set it to true? What more do we Once we have the orchestration tool checked-in we can flip this flag and remove the hidden tag as well. http://gerrit.cloudera.org:8080/#/c/17180/2/src/kudu/master/master_service.cc@101 PS2, Line 101: TAG_FLAG(master_support_change_config, advanced); > Should this be labeled 'advanced'? What's unsafe about it? advanced is more accurate. -- To view, visit http://gerrit.cloudera.org:8080/17180 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I72b37ba9ff3c48bce532ad3d037d341c2c36bb9f Gerrit-Change-Number: 17180 Gerrit-PatchSet: 3 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 31 Mar 2021 18:01:39 +0000 Gerrit-HasComments: Yes
