Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17263 )
Change subject: KUDU-2612: rollback txn on TXN_LOCKED_ABORT ...................................................................... Patch Set 6: (4 comments) Looks good to me, just one question and a few nits. http://gerrit.cloudera.org:8080/#/c/17263/6/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/17263/6/src/kudu/tserver/tablet_service.cc@684 PS6, Line 684: virtual nit: drop 'virtual' ? http://gerrit.cloudera.org:8080/#/c/17263/6/src/kudu/tserver/ts_tablet_manager.h File src/kudu/tserver/ts_tablet_manager.h: http://gerrit.cloudera.org:8080/#/c/17263/6/src/kudu/tserver/ts_tablet_manager.h@247 PS6, Line 247: // Schedule preliminary tasks to begin transaction 'txn_id' started by 'user' Ah, thank you for filling in the gap. It seems I left this comment unfinished. http://gerrit.cloudera.org:8080/#/c/17263/6/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/17263/6/src/kudu/tserver/ts_tablet_manager.cc@1905 PS6, Line 1905: "Sending abort request for transaction " << txn_id; nit: maybe, use Substitute() here as well? http://gerrit.cloudera.org:8080/#/c/17263/6/src/kudu/tserver/ts_tablet_manager.cc@1909 PS6, Line 1909: std::lock_guard<simple_spinlock> l(txn_aborts_lock_); : txn_aborts_in_progress_.erase(txn_id); Does it make sense to keep the entry in the container and retry the task in case of particular errors, e.g. Status::TimedOut() and transient errors like NetworkError? -- To view, visit http://gerrit.cloudera.org:8080/17263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I25415cad0cfb08d260e23bd8b368852a5006c1fb Gerrit-Change-Number: 17263 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 21 Apr 2021 00:53:35 +0000 Gerrit-HasComments: Yes
