Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17328 )
Change subject: [spark] KUDU-1884 Add custom SASL protocol name ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17328/2/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala: http://gerrit.cloudera.org:8080/#/c/17328/2/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@66 PS2, Line 66: val saslProtocolName: Option[String]) > I believe so, isn't it the default? no. You are require to pass None for this constructor. Hence the modification of this(...) below. You can add `= None` here. -- To view, visit http://gerrit.cloudera.org:8080/17328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd0dba4f829f369c363cc89bb58650249035f356 Gerrit-Change-Number: 17328 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 22 Apr 2021 19:23:44 +0000 Gerrit-HasComments: Yes
