Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17354 )
Change subject: [thirdparty] Force Boost to use /dev/random for uuid ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/17354/2/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/17354/2/thirdparty/build-definitions.sh@842 PS2, Line 842: -fPIC This is already added at line 835, no? http://gerrit.cloudera.org:8080/#/c/17354/2/thirdparty/build-definitions.sh@842 PS2, Line 842: EXTRA_CFLAGS Should this be BOOST_CFLAGS instead to not override the flags set a couple of lines above? http://gerrit.cloudera.org:8080/#/c/17354/2/thirdparty/build-definitions.sh@843 PS2, Line 843: EXTRA_CXXFLAGS ditto http://gerrit.cloudera.org:8080/#/c/17354/2/thirdparty/build-definitions.sh@843 PS2, Line 843: -fPIC Drop this since -fPIC is already added at line 836? http://gerrit.cloudera.org:8080/#/c/17354/2/thirdparty/build-definitions.sh@847 PS2, Line 847: # BOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX nit: remove this extra commented line? -- To view, visit http://gerrit.cloudera.org:8080/17354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I229f691ed851617e2aa183465726b8cc5e10039c Gerrit-Change-Number: 17354 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 28 Apr 2021 03:54:27 +0000 Gerrit-HasComments: Yes
