Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17356 )
Change subject: KUDU-2612: propagate commit timestamp (Java client) ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/17356/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTransaction.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduTransaction.java: http://gerrit.cloudera.org:8080/#/c/17356/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTransaction.java@557 PS1, Line 557: if (resp.hasCommitTimestamp()) { : client.updateLastPropagatedTimestamp(resp.getCommitTimestamp()); : } Do we still need this if we're calling it at isCommitComplete()? -- To view, visit http://gerrit.cloudera.org:8080/17356 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4177fe0d137b70bd18dd6c87eb42e8aaf03a00b3 Gerrit-Change-Number: 17356 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 28 Apr 2021 21:13:36 +0000 Gerrit-HasComments: Yes
