Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17360 )

Change subject: [doc] KUDU-2181 Recover dead master doc updates
......................................................................


Patch Set 2:

(4 comments)

Looking through the staged version, while the steps themselves are certainly 
simpler for 1.15, the docs themselves have grown quite a bit longer given all 
the branching for versioning.

It's not what we've been doing historically, but I wonder if it's worth 
pointing to 1.14 docs up front if the user is on an older version, and simply 
getting rid of the pre-1.15 multi-master migration docs on master. Other 
versioned tooling suffer from the same issue, and so maybe this should be the 
policy in general. Curious what others think.

http://gerrit.cloudera.org:8080/#/c/17360/2/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/17360/2/docs/administration.adoc@611
PS2, Line 611: ng
nit: using the


http://gerrit.cloudera.org:8080/#/c/17360/2/docs/administration.adoc@826
PS2, Line 826: need to
nit: remove "need to"


http://gerrit.cloudera.org:8080/#/c/17360/2/docs/administration.adoc@826
PS2, Line 826: version
nit: here and elsewhere, consider pluralizing "versions"


http://gerrit.cloudera.org:8080/#/c/17360/2/docs/administration.adoc@901
PS2, Line 901: alias is
nit: "aliases are not being used"



--
To view, visit http://gerrit.cloudera.org:8080/17360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id578976428c98f7378820ca71156647fa9ac6928
Gerrit-Change-Number: 17360
Gerrit-PatchSet: 2
Gerrit-Owner: Bankim Bhavsar <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 30 Apr 2021 01:19:01 +0000
Gerrit-HasComments: Yes

Reply via email to