Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17359 )
Change subject: [doc] KUDU-2181 Remove master doc changes ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/17359/2/docs/administration.adoc File docs/administration.adoc: http://gerrit.cloudera.org:8080/#/c/17359/2/docs/administration.adoc@971 PS2, Line 971: . Stop process(es): I'm a little hesitant to document special steps for CM just yet, given I think the desired end-state is that there will be a button that does much of this automatically. I feel the same way about the add master tool. It's true that these work as is for presumably most versions of CM that can manage Kudu 1.15, but I worry it may eventually get confusing when the steps change in certain CDP releases that aren't necessarily tied to upstream versions (e.g. if these steps change in CDP 7.2, it's a bit unclear how to update these steps). http://gerrit.cloudera.org:8080/#/c/17359/2/docs/administration.adoc@975 PS2, Line 975: role(s). Aren't we only removing one at a time? Should this be singular? http://gerrit.cloudera.org:8080/#/c/17359/2/docs/administration.adoc@1000 PS2, Line 1000: (Re) micro-nit: IMO these are a bit distracting and don't add much. Seems like they're all implied to be restarts. Same elsewhere with "role(s)" and "process(es)". -- To view, visit http://gerrit.cloudera.org:8080/17359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58b584a1487dc0be4a2479aa80d1464f68d9fce5 Gerrit-Change-Number: 17359 Gerrit-PatchSet: 2 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 30 Apr 2021 01:07:04 +0000 Gerrit-HasComments: Yes
