Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17367 )
Change subject: [client] return TimedOut if the deadline has passed in master RPCs ...................................................................... [client] return TimedOut if the deadline has passed in master RPCs There was a narrow window in which we could return a NetworkError to users of the master-bound RPCs instead of a TimedOut error. Without this change I saw ClientTest.NoTxnManager fail 1/300 times and TxnStatusTableITest.TestSystemClientMasterDown fail ~1/3 of the time running in a loop via dist-test. With this change, I ran it with no issue 1000/1000 times each. This is a follow-up to 96047a8d861d61673b9e2589930eccd78a16e483. Change-Id: I309ba70d62a48b4dc8fb0e8f30f532593c254860 Reviewed-on: http://gerrit.cloudera.org:8080/17367 Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Andrew Wong <[email protected]> --- M src/kudu/client/master_proxy_rpc.cc M src/kudu/client/txn_manager_proxy_rpc.cc 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Andrew Wong: Verified -- To view, visit http://gerrit.cloudera.org:8080/17367 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I309ba70d62a48b4dc8fb0e8f30f532593c254860 Gerrit-Change-Number: 17367 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
