Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17369 )
Change subject: [rpc] add transport-specific info for RPC connections ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/17369/1/src/kudu/rpc/connection.cc File src/kudu/rpc/connection.cc: http://gerrit.cloudera.org:8080/#/c/17369/1/src/kudu/rpc/connection.cc@1015 PS1, Line 1015: int ret = ::getsockopt(fd, IPPROTO_TCP, TCP_MAXSEG, &max_seg_size, &optlen); : if (ret) { : int err = errno; : return Status::NetworkError( : "getsockopt(TCP_MAXSEG) failed", ErrnoToString(err), err); : } > Sure, how about moving the TLS info up before getsockopt then, so at least Ah oops. Missed that you mentioned it's irrelevant. Please disregard. -- To view, visit http://gerrit.cloudera.org:8080/17369 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib712f98b93dd5ee12c2083467261af02863c18e8 Gerrit-Change-Number: 17369 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 30 Apr 2021 19:31:25 +0000 Gerrit-HasComments: Yes
