Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17377 )
Change subject: [test] fix flakiness in RegistrationTest.TestTSRegisters ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17377/1/src/kudu/integration-tests/registration-test.cc File src/kudu/integration-tests/registration-test.cc: http://gerrit.cloudera.org:8080/#/c/17377/1/src/kudu/integration-tests/registration-test.cc@a261 PS1, Line 261: > Yeah, that's what line 250 is about. I mean that's exactly what happens now in the updated code: at line 250 'seqno' is captured before the restart (and ASSERT_EQ at line 254 confirms that the captured 'seqno' is that's expected), and then at line 264 there is ASSERT_GT which makes sure that post-restart 'seqno' is higher than before the restart. -- To view, visit http://gerrit.cloudera.org:8080/17377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6b072409d2a68bc2ad621c1c021b0f4b3143fb2 Gerrit-Change-Number: 17377 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 03 May 2021 04:29:45 +0000 Gerrit-HasComments: Yes
