Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17370 )
Change subject: [txns][tools] tool to list transactions ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/17370/5/src/kudu/tools/tool_action_txns.cc File src/kudu/tools/tool_action_txns.cc: http://gerrit.cloudera.org:8080/#/c/17370/5/src/kudu/tools/tool_action_txns.cc@151 PS5, Line 151: show_hybrid_timestamps > I prefer this pluralized version because "show_hybrid_timestamp" makes it s Yep, that sounds reasonable to me. >From the other side, what to you think of the configurable list of columns >here instead of adding flags like this show_hybrid_timestamps? Then it will >be no question about how to call this flag, because there would be no such one >:) E.g., see https://github.com/apache/kudu/blob/28a3baab6149ee9317c71a4afc04ad4f3c8da2f9/src/kudu/tools/tool_action_master.cc#L789-L795 -- To view, visit http://gerrit.cloudera.org:8080/17370 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6136fe8eea7842802c5a84609a0c8e2101f6a693 Gerrit-Change-Number: 17370 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 05 May 2021 04:40:46 +0000 Gerrit-HasComments: Yes
