Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17401 )
Change subject: [master] KUDU-2181 Unhide master change config flag & other improvements ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/17401/2/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/17401/2/src/kudu/master/master_service.cc@101 PS2, Line 101: TAG_FLAG(master_support_change_config, evolving); nit: a flag is tagged 'evolving' by default if not marked 'stable' or 'experimental', so unless you want to point at that specifically, this line might be omitted http://gerrit.cloudera.org:8080/#/c/17401/2/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/17401/2/src/kudu/tools/tool_action_master.cc@76 PS2, Line 76: 8 I recall during one presentation this was set to something higher, like 30 seconds because of corresponding timeout to wait for clock synchronization. Does it make sense to set it to 30 seconds by default? http://gerrit.cloudera.org:8080/#/c/17401/2/src/kudu/tools/tool_action_master.cc@175 PS2, Line 175: // In case of an error in bringing up the master we want to ensure the last log lines : // are emitted to help debug the issue. Hence turn off log buffering. : flags.emplace_back("--logbuflevel=-1"); BTW, what about --log_async flag for the newly started master? In addition to glog flags, kudu server processes also utilize async logger: src/kudu/util/logging.{h,cc} -- To view, visit http://gerrit.cloudera.org:8080/17401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1fc1dc5985601158ae58d5d190a60c1e542ea1d Gerrit-Change-Number: 17401 Gerrit-PatchSet: 2 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 14 May 2021 17:28:04 +0000 Gerrit-HasComments: Yes
