Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17446 )
Change subject: [txns] add a means to get transaction metadata from participant ...................................................................... Patch Set 3: Code-Review+1 (2 comments) overall looks good, just a few nits http://gerrit.cloudera.org:8080/#/c/17446/3/src/kudu/integration-tests/txn_participant-itest.cc File src/kudu/integration-tests/txn_participant-itest.cc: http://gerrit.cloudera.org:8080/#/c/17446/3/src/kudu/integration-tests/txn_participant-itest.cc@873 PS3, Line 873: ASSERT_FALSE(meta_pb.has_aborted()); Does it make sense to add coverage to make sure this field is populated when a transaction is aborted? http://gerrit.cloudera.org:8080/#/c/17446/3/src/kudu/tserver/tserver_admin.proto File src/kudu/tserver/tserver_admin.proto: http://gerrit.cloudera.org:8080/#/c/17446/3/src/kudu/tserver/tserver_admin.proto@127 PS3, Line 127: empty nit: if no metadata exists on the given participant, is it going to be rather absent or present and empty? Would be nice to clarify. -- To view, visit http://gerrit.cloudera.org:8080/17446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b03f13f174bd9a83609fb7ed6106746777b4207 Gerrit-Change-Number: 17446 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 15 May 2021 06:33:49 +0000 Gerrit-HasComments: Yes
