Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17444 )
Change subject: KUDU-3223: management of per-table limit by kudu CLI ...................................................................... Patch Set 15: (5 comments) http://gerrit.cloudera.org:8080/#/c/17444/15//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17444/15//COMMIT_MSG@11 PS15, Line 11: If the kudu-master does not set "-enable_table_write_limit=true" How about: If '--enable_table_write_limit' is not set 'true' for kudu-master http://gerrit.cloudera.org:8080/#/c/17444/15//COMMIT_MSG@12 PS15, Line 12: cli nit: CLI http://gerrit.cloudera.org:8080/#/c/17444/15//COMMIT_MSG@12 PS15, Line 12: failed nit: fails http://gerrit.cloudera.org:8080/#/c/17444/15//COMMIT_MSG@15 PS15, Line 15: Only kudu-master sets "-enable_table_write_limit=true" How about: Only when '--enable_table_write_limit' is set 'true' http://gerrit.cloudera.org:8080/#/c/17444/15//COMMIT_MSG@15 PS15, Line 15: cli nit: CLI -- To view, visit http://gerrit.cloudera.org:8080/17444 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I59bb64cc85d5fca48ae8ec980f5cfc62e4b3a1d3 Gerrit-Change-Number: 17444 Gerrit-PatchSet: 15 Gerrit-Owner: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 21 May 2021 00:02:24 +0000 Gerrit-HasComments: Yes
