Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17504 )
Change subject: [test] minor clean up on TestUnsafeChangeConfigLeaderWithPendingConfig ...................................................................... Patch Set 1: > Patch Set 1: > > > Why remove those info log lines? > > Because they are useless in an automated tests. They might make sense during > developing of the test, but there isn't much sense keeping them since nobody > looks at them during regular runs. If a test scenario fails, the information > in the assert messages should be enough to start troubleshooting. They could help debug in case of a test failure. I'm not convinced removing log lines is the right thing to do unless it's causing log spew and making debugging even more difficult. -- To view, visit http://gerrit.cloudera.org:8080/17504 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2bf354764f3ddb371de19910c5f879c1a06c78b Gerrit-Change-Number: 17504 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Comment-Date: Tue, 25 May 2021 23:09:23 +0000 Gerrit-HasComments: No
