Grant Henke has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/17514 )
Change subject: [test] minor clean up on
TestUnsafeChangeConfigLeaderWithPendingConfig
......................................................................
[test] minor clean up on TestUnsafeChangeConfigLeaderWithPendingConfig
When looking at one of recent pre-commit test failure [1][2], I found
that AdminCliTest.TestUnsafeChangeConfigLeaderWithPendingConfig failed
but it was hard to tell what was the actual status code returned:
src/kudu/tools/kudu-admin-test.cc:881: Failure
Value of: s.IsTimedOut()
Actual: false
Expected: true
I reran the scenario multiple times with TSAN-enabled binaries, but
was not able to reproduce the test failure yet. Anyways, I added more
diagnostics about the actual status code returned and cleaned up the
code of the test scenario a bit. Hopefully, next time it fails it
will be clearer what's going on.
[1] http://jenkins.kudu.apache.org/job/kudu-gerrit/23918/BUILD_TYPE=TSAN
[2] http://dist-test.cloudera.org/job?job_id=jenkins-slave.1621893605.3746155
Change-Id: Id2bf354764f3ddb371de19910c5f879c1a06c78b
Reviewed-on: http://gerrit.cloudera.org:8080/17504
Tested-by: Kudu Jenkins
Reviewed-by: Mahesh Reddy <mre...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Grant Henke <granthe...@apache.org>
(cherry picked from commit a0bda0989d97fac182f409ecaef3357a1fb5329f)
Reviewed-on: http://gerrit.cloudera.org:8080/17514
Reviewed-by: Alexey Serbin <aser...@cloudera.com>
---
M src/kudu/tools/kudu-admin-test.cc
1 file changed, 7 insertions(+), 13 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17514
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2bf354764f3ddb371de19910c5f879c1a06c78b
Gerrit-Change-Number: 17514
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
