Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17510 )
Change subject: [txn_manager] allow a super user to call txn-related RPCs ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/17510/3/src/kudu/master/txn_manager_service.cc File src/kudu/master/txn_manager_service.cc: http://gerrit.cloudera.org:8080/#/c/17510/3/src/kudu/master/txn_manager_service.cc@167 PS3, Line 167: AuthorizeClient > nit: for consistency with the MasterService, let's call this AuthorizeClien As I understand, renaming this into AuthorizeClientOrServiceUser would bring some inconsistency since AuthorizeClientOrServiceUser() assumes a service user is also granted a privilege, but here it's not the case. Below is the code for AuthorizeClientOrServiceUser() from tserver: bool TabletServiceImpl::AuthorizeClientOrServiceUser(const google::protobuf::Message* /*req*/, google::protobuf::Message* /*resp*/, RpcContext* context) { return server_->Authorize(context, ServerBase::SUPER_USER | ServerBase::USER | ServerBase::SERVICE_USER); } -- To view, visit http://gerrit.cloudera.org:8080/17510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21e4b29634fd01f0ced80b54373b1ce156e274ad Gerrit-Change-Number: 17510 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 26 May 2021 18:38:25 +0000 Gerrit-HasComments: Yes
