Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17529 )

Change subject: WIP: KUDU-2612 allow system user to read list of table replicas
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17529/1/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/17529/1/src/kudu/master/catalog_manager.cc@5536
PS1, Line 5536: && !master_->IsServiceUserOrSuperUser(*user)) {
              :     // Acquire the table lock and then check that the user is 
authorized to operate on
              :     // the table that the tablet belongs to.
              :     TableMetadataLock table_lock(tablet_info->table().get(), 
LockMode::READ);
> That would not work -- the essence of this check is to make sure that txn_s
I guess what I wanted to point is that in this context the service user that is 
used for txn-client needs METADATA privilege to call GetTabletLocations() for 
any user table which rows were inserted in the context of a multi-row 
transaction.



--
To view, visit http://gerrit.cloudera.org:8080/17529
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26f06af17e5ee85522e2ef867d41cf0f3ddbe5d5
Gerrit-Change-Number: 17529
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 01 Jun 2021 18:08:39 +0000
Gerrit-HasComments: Yes

Reply via email to