Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17525 )
Change subject: [docs] add a design overview for multi-row transactions ...................................................................... Patch Set 2: (23 comments) http://gerrit.cloudera.org:8080/#/c/17525/2/docs/design-docs/transactions.adoc File docs/design-docs/transactions.adoc: http://gerrit.cloudera.org:8080/#/c/17525/2/docs/design-docs/transactions.adoc@27 PS2, Line 27: To enable > Is it worth mentioning that at least 3 tablet servers are required in a Kud Done http://gerrit.cloudera.org:8080/#/c/17525/2/docs/design-docs/transactions.adoc@33 PS2, Line 33: new terminology > Do we have a special term to denote a component that uses txn-related API Done, added as "Transaction handle". http://gerrit.cloudera.org:8080/#/c/17525/2/docs/design-docs/transactions.adoc@40 PS2, Line 40: distributed table with a rough schema > Is this also some sort of 'logical' schema? If so, does it make sense to m Done http://gerrit.cloudera.org:8080/#/c/17525/2/docs/design-docs/transactions.adoc@58 PS2, Line 58: Before delving into the details of each component > nit: is it worth mentioning that the txn status table is assumed to be of R Done http://gerrit.cloudera.org:8080/#/c/17525/2/docs/design-docs/transactions.adoc@69 PS2, Line 69: Upon successfully Raft committing the status record > nit: what about Done http://gerrit.cloudera.org:8080/#/c/17525/2/docs/design-docs/transactions.adoc@98 PS2, Line 98: the commit > ... that the commit ... ? Done http://gerrit.cloudera.org:8080/#/c/17525/2/docs/design-docs/transactions.adoc@103 PS2, Line 103: a proxy > nit: as proxies ? Done http://gerrit.cloudera.org:8080/#/c/17525/2/docs/design-docs/transactions.adoc@132 PS2, Line 132: once the first BeginTransaction() request is received > Does it make sense to throw in an info about configuring this behavior usin Done http://gerrit.cloudera.org:8080/#/c/17525/2/docs/design-docs/transactions.adoc@134 PS2, Line 134: ranges are added > Is it worth mentioning the --txn_manager_status_table_range_partition_span Done http://gerrit.cloudera.org:8080/#/c/17525/2/docs/design-docs/transactions.adoc@178 PS2, Line 178: majority of : replicas > nit: the transaction status tablet's replicas Done http://gerrit.cloudera.org:8080/#/c/17525/2/docs/design-docs/transactions.adoc@191 PS2, Line 191: will be blocked > nit: will be blocked by the Raft protocol ? Done http://gerrit.cloudera.org:8080/#/c/17525/2/docs/design-docs/transactions.adoc@196 PS2, Line 196: Background orchestration tasks > An incomplete sentence or the paragraph marking is missing? Done http://gerrit.cloudera.org:8080/#/c/17525/2/docs/design-docs/transactions.adoc@219 PS2, Line 219: The `TxnStatusManagers` get heartbeat to by clients via the `TxnManager` in order to identify : abandoned transactions > What about: Done http://gerrit.cloudera.org:8080/#/c/17525/2/docs/design-docs/transactions.adoc@225 PS2, Line 225: are aborted > nit: are automatically aborted Done http://gerrit.cloudera.org:8080/#/c/17525/2/docs/design-docs/transactions.adoc@266 PS2, Line 266: map > nit: registry Done http://gerrit.cloudera.org:8080/#/c/17525/2/docs/design-docs/transactions.adoc@270 PS2, Line 270: temporarily and asynchronously uses the : `TxnSystemClient` to asynchronously register > maybe, replace with: Done http://gerrit.cloudera.org:8080/#/c/17525/2/docs/design-docs/transactions.adoc@273 PS2, Line 273: resubmitted > submitted Done http://gerrit.cloudera.org:8080/#/c/17525/2/docs/design-docs/transactions.adoc@279 PS2, Line 279: removed from the map > nit: unregistered Done http://gerrit.cloudera.org:8080/#/c/17525/2/docs/design-docs/transactions.adoc@351 PS2, Line 351: a transaction > nit: a multi-row transaction inserting rows into the same tablet Done http://gerrit.cloudera.org:8080/#/c/17525/2/docs/design-docs/transactions.adoc@356 PS2, Line 356: which serve > Does it make sense to mention that txn handles, while kept in scope, are al Done http://gerrit.cloudera.org:8080/#/c/17525/2/docs/design-docs/transactions.adoc@367 PS2, Line 367: KUDU_RETURN_NOT_OK(session->Flush()); > This piece isn't strictly necessary, but I guess we want to keep it here ju Right, it's a good practice to have. http://gerrit.cloudera.org:8080/#/c/17525/2/docs/design-docs/transactions.adoc@384 PS2, Line 384: Users > Client applications Done http://gerrit.cloudera.org:8080/#/c/17525/2/docs/design-docs/transactions.adoc@414 PS2, Line 414: by passing `SerializationOptions` > nit: by passing customized `SerializationOptions` Done -- To view, visit http://gerrit.cloudera.org:8080/17525 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I14c5a8cbd2b239c68e355910e9a6de4576508dd6 Gerrit-Change-Number: 17525 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 02 Jun 2021 20:26:13 +0000 Gerrit-HasComments: Yes
