Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17526 )
Change subject: WIP KUDU-3265 txn-related options to 'kudu perf loadgen' ...................................................................... Patch Set 2: (1 comment) +1 for the approach. http://gerrit.cloudera.org:8080/#/c/17526/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17526/2//COMMIT_MSG@22 PS2, Line 22: A follow-up patch will add : functionality to write and read transactional tokens in serialized form, Would it instead make sense to allow users to supply the txn ID, and print the started txn ID? I guess it's more future-proof to have this be the entire token, but I wonder how cumbersome this is. -- To view, visit http://gerrit.cloudera.org:8080/17526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73750af589d432c6ae973439264f55c08a327aa7 Gerrit-Change-Number: 17526 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 02 Jun 2021 22:20:38 +0000 Gerrit-HasComments: Yes
