Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17558 )
Change subject: [client] replace Equals() with operator==() ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/17558/1/src/kudu/client/client-unittest.cc File src/kudu/client/client-unittest.cc: http://gerrit.cloudera.org:8080/#/c/17558/1/src/kudu/client/client-unittest.cc@328 PS1, Line 328: ASSERT_TRUE(a32 != b32); What additional purpose does this 'ASSERT_TRUE' statement add considering the 'ASSERT_FALSE' statement directly before it? http://gerrit.cloudera.org:8080/#/c/17558/1/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/17558/1/src/kudu/tools/table_scanner.cc@354 PS1, Line 354: d nit: Capitalize 'd' in destination. -- To view, visit http://gerrit.cloudera.org:8080/17558 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a95534835c93b1fb7a3ca1f311c530572c50ad2 Gerrit-Change-Number: 17558 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 08 Jun 2021 06:39:00 +0000 Gerrit-HasComments: Yes
