Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17563 )
Change subject: [client] replace Equals() with operator==() ...................................................................... [client] replace Equals() with operator==() This patch replaces the 'bool Equals(const X&)' method for Partition and PartitionSchema classes with 'bool operator==(const X&)'. For KuduSchema and KuduColumnSchema, both operator==() and operator!=() were introduced, and the Equals() method was marked as deprecated since KuduSchema's and KuduColumnsSchema's API are public at this point. I decided to perform minor refactoring while changing other code around: the presence of Equals() method looks a bit lame in a C++ API. This patch doesn't contain any functional modifications. Change-Id: I4a95534835c93b1fb7a3ca1f311c530572c50ad2 Reviewed-on: http://gerrit.cloudera.org:8080/17558 Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong <aw...@cloudera.com> (cherry picked from commit 79bd57546996c6e3c130960ba099fb637d58d51f) Reviewed-on: http://gerrit.cloudera.org:8080/17563 Reviewed-by: Bankim Bhavsar <ban...@cloudera.com> --- M src/kudu/client/client-test.cc M src/kudu/client/client-unittest.cc M src/kudu/client/schema.cc M src/kudu/client/schema.h M src/kudu/common/partition-test.cc M src/kudu/common/partition.cc M src/kudu/common/partition.h M src/kudu/integration-tests/alter_table-test.cc M src/kudu/integration-tests/test_workload.cc M src/kudu/tablet/tablet_metadata.cc M src/kudu/tools/table_scanner.cc 11 files changed, 117 insertions(+), 44 deletions(-) Approvals: Kudu Jenkins: Verified Andrew Wong: Looks good to me, approved Bankim Bhavsar: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.15.x Gerrit-MessageType: merged Gerrit-Change-Id: I4a95534835c93b1fb7a3ca1f311c530572c50ad2 Gerrit-Change-Number: 17563 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120)
