Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17554 )
Change subject: [rest] add oat++ framework to kudu ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/17554/5/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/17554/5/CMakeLists.txt@1492 PS5, Line 1492: add_subdirectory(src/kudu/rest) this should be in alphabetical order http://gerrit.cloudera.org:8080/#/c/17554/5/cmake_modules/FindOatpp.cmake File cmake_modules/FindOatpp.cmake: http://gerrit.cloudera.org:8080/#/c/17554/5/cmake_modules/FindOatpp.cmake@16 PS5, Line 16: # under the License. nit: add an extra newline to separate the license portion from the content http://gerrit.cloudera.org:8080/#/c/17554/5/cmake_modules/FindOatppSwagger.cmake File cmake_modules/FindOatppSwagger.cmake: http://gerrit.cloudera.org:8080/#/c/17554/5/cmake_modules/FindOatppSwagger.cmake@16 PS5, Line 16: # under the License. same as in the other cmake file http://gerrit.cloudera.org:8080/#/c/17554/5/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/17554/5/thirdparty/build-definitions.sh@1116 PS5, Line 1116: make -j$PARALLEL install nit: indent -- To view, visit http://gerrit.cloudera.org:8080/17554 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1b5376297b0170a624655acf836cdedc090f6e7 Gerrit-Change-Number: 17554 Gerrit-PatchSet: 5 Gerrit-Owner: Khazar Mammadli <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 10 Jun 2021 12:07:38 +0000 Gerrit-HasComments: Yes
