Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17584 )
Change subject: [util] flag to specify hosts to fail DNS resolution ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17584/1/src/kudu/util/net/net_util.cc File src/kudu/util/net/net_util.cc: http://gerrit.cloudera.org:8080/#/c/17584/1/src/kudu/util/net/net_util.cc@228 PS1, Line 228: if (ContainsKey(failed_hostports, ToString())) { Nit:To ensure no white spacing issue or missing/default port, it'd be better to compare HostPort/Sockaddr instead of strings. -- To view, visit http://gerrit.cloudera.org:8080/17584 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I25f2d3073fa0fa0a430afacf7c8cd1402e6bd6ab Gerrit-Change-Number: 17584 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 11 Jun 2021 16:24:13 +0000 Gerrit-HasComments: Yes
