Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17556 )
Change subject: [rest] add rest to master servers ...................................................................... Patch Set 10: (9 comments) http://gerrit.cloudera.org:8080/#/c/17556/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17556/10//COMMIT_MSG@9 PS10, Line 9: and nit: missing space http://gerrit.cloudera.org:8080/#/c/17556/10//COMMIT_MSG@10 PS10, Line 10: best choice best choice of which options? http://gerrit.cloudera.org:8080/#/c/17556/10/src/kudu/master/CMakeLists.txt File src/kudu/master/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/17556/10/src/kudu/master/CMakeLists.txt@97 PS10, Line 97: rest) nit: alphabetical order http://gerrit.cloudera.org:8080/#/c/17556/10/src/kudu/master/master.cc File src/kudu/master/master.cc: http://gerrit.cloudera.org:8080/#/c/17556/10/src/kudu/master/master.cc@98 PS10, Line 98: DEFINE_bool(rest_server_enabled,false,"Should a rest endpoint be enabled on this master"); these should be tagged as experimental http://gerrit.cloudera.org:8080/#/c/17556/10/src/kudu/master/master.cc@99 PS10, Line 99: DEFINE_string(rest_server_bind_address,"","Address where the rest server should start up"); shouldn't we add a default bind address for this? http://gerrit.cloudera.org:8080/#/c/17556/10/src/kudu/master/master.cc@188 PS10, Line 188: if(FLAGS_rest_server_enabled) { nit: missing space http://gerrit.cloudera.org:8080/#/c/17556/10/src/kudu/master/master.cc@189 PS10, Line 189: FLAGS_rest_server_bind_address nit: missing space http://gerrit.cloudera.org:8080/#/c/17556/10/src/kudu/master/master.cc@273 PS10, Line 273: if(rest_server_) { nit: missing space http://gerrit.cloudera.org:8080/#/c/17556/10/src/kudu/master/master.cc@278 PS10, Line 278: nit: extra spaces -- To view, visit http://gerrit.cloudera.org:8080/17556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ae85888686dbe3a532f1447aafefb4bc6125ee3 Gerrit-Change-Number: 17556 Gerrit-PatchSet: 10 Gerrit-Owner: Khazar Mammadli <mammadli.kha...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 14 Jun 2021 13:35:51 +0000 Gerrit-HasComments: Yes
