Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17577 )
Change subject: [rest] add integration test ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/17577/2/src/kudu/integration-tests/CMakeLists.txt File src/kudu/integration-tests/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/17577/2/src/kudu/integration-tests/CMakeLists.txt@150 PS2, Line 150: ADD_KUDU_TEST(rest_server-itest) nit: alphabetical order http://gerrit.cloudera.org:8080/#/c/17577/2/src/kudu/integration-tests/rest_server-itest.cc File src/kudu/integration-tests/rest_server-itest.cc: http://gerrit.cloudera.org:8080/#/c/17577/2/src/kudu/integration-tests/rest_server-itest.cc@61 PS2, Line 61: KuduTableCreator* table_creator = client_->NewTableCreator(); can you use a smart pointer here? http://gerrit.cloudera.org:8080/#/c/17577/2/src/kudu/integration-tests/rest_server-itest.cc@81 PS2, Line 81: string data = maybe it would be easier and more readable to use EasyJson to set up the JSON string? http://gerrit.cloudera.org:8080/#/c/17577/2/src/kudu/integration-tests/rest_server-itest.cc@105 PS2, Line 105: } nit: extra new line -- To view, visit http://gerrit.cloudera.org:8080/17577 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1b2900c67d601fa5a3a747d2475e1e86a6ad2e3 Gerrit-Change-Number: 17577 Gerrit-PatchSet: 2 Gerrit-Owner: Khazar Mammadli <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 14 Jun 2021 13:43:41 +0000 Gerrit-HasComments: Yes
