Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17597 )
Change subject: [tools] use --timeout_ms in tablet_scanner ...................................................................... [tools] use --timeout_ms in tablet_scanner This patch removes the hard-coded timeout in TableScanner::CopyTask() and TableScanner::StartWork() methods, switching them to using the --timeout_ms run-time flag. In addition, I sneaked in a code clean-up: * use std::atomic instead of Atomic in table_scanner * use 'constexpr const char* const' in kudu-tool-test * groups DECLARE_xxx separately from DEFINE_xxx Change-Id: Id9ec546cb5cb9c94d13705596517258ee15330f1 Reviewed-on: http://gerrit.cloudera.org:8080/17597 Reviewed-by: Andrew Wong <aw...@cloudera.com> Tested-by: Kudu Jenkins --- M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/table_scanner.cc M src/kudu/tools/table_scanner.h M src/kudu/tools/tool_action_perf.cc 4 files changed, 56 insertions(+), 52 deletions(-) Approvals: Andrew Wong: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/17597 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id9ec546cb5cb9c94d13705596517258ee15330f1 Gerrit-Change-Number: 17597 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120)
