Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17598 )
Change subject: [tools] add --row_count_only and --report_scanner_stats flags ...................................................................... Patch Set 2: (1 comment) Neat addition! Though it looks like the newly updated tests aren't happy yet. http://gerrit.cloudera.org:8080/#/c/17598/2/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/17598/2/src/kudu/tools/kudu-tool-test.cc@2848 PS2, Line 2848: ASSERT_TRUE(s.ok()) << s.ToString() << ": " << err; nit: would it make sense to also check there are no row outputs? I guess that might be tricky, so maybe not. -- To view, visit http://gerrit.cloudera.org:8080/17598 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia64e1a0b26996f0087d2473d15350d590581a69c Gerrit-Change-Number: 17598 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 16 Jun 2021 20:16:02 +0000 Gerrit-HasComments: Yes
