Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17605 )
Change subject: [tools] --replica_selection flag for 'table scan' and 'perf table_scan' ...................................................................... [tools] --replica_selection flag for 'table scan' and 'perf table_scan' This patch adds replica selection configuration knob for the `kudu table scan` and `kudu perf table_scan` CLI tools by introducing --replica_selection flag. Acceptable values for the newly introduced flag are CLOSEST and LEADER, case insensitive. I decided not to expose ReplicaSelection::FIRST_REPLICA enumeration value via the new flag: the semantics of FIRST_REPLICA is too hazy and I could not see how it might bring any value in practice. This patch also contains corresponding tests. Change-Id: Ie8ac1e91f0c03c61edd19796d69cecaf68880a5b Reviewed-on: http://gerrit.cloudera.org:8080/17605 Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong <[email protected]> --- M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/table_scanner.cc M src/kudu/tools/table_scanner.h M src/kudu/tools/tool_action_perf.cc M src/kudu/tools/tool_action_table.cc 5 files changed, 211 insertions(+), 61 deletions(-) Approvals: Kudu Jenkins: Verified Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17605 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie8ac1e91f0c03c61edd19796d69cecaf68880a5b Gerrit-Change-Number: 17605 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
