Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17582 )
Change subject: [clock] change clock source selection for 'auto' ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/17582/3/src/kudu/clock/hybrid_clock.cc File src/kudu/clock/hybrid_clock.cc: http://gerrit.cloudera.org:8080/#/c/17582/3/src/kudu/clock/hybrid_clock.cc@476 PS3, Line 476: // Switch to the built-in NTP client unless the set of reference servers > In the case the built-in NTP client can't reach the configured ntp servers, Sure: it's possible to detect that, but it will require extra time waiting for the built-in client to sync-up and then bail if it could not. The risk here is that due to transient networking issue some nodes might fallback to the system, while others might be able to get it working with the built-in NTP client. With that, do you think we need some sort of flag to gate that probing behavior? -- To view, visit http://gerrit.cloudera.org:8080/17582 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I72cb54c488b2aa2c73acd6e6e5f6e50dd5811175 Gerrit-Change-Number: 17582 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 21 Jun 2021 19:20:09 +0000 Gerrit-HasComments: Yes
