Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/17673 )
Change subject: [client] actionable error message for KuduSession::Flush()
......................................................................
[client] actionable error message for KuduSession::Flush()
This patch makes the error message for Status::IOError() returned by
KuduSession::Flush() more actionable, citing that details are available
via call to KuduSession::GetPendingErrors(). Yes, that's documented
in-line in client.h and in the client C++ API docs [1], but who reads
those?
Prior to this patch, the error message was:
Some errors occurred
With this patch, the error message now is:
failed to flush data: error details are available
via KuduSession::GetPendingErrors()
In addition, I switched the code in batcher.{h,cc} from Atomic
(util/atomic.h and gutil/atomicops.h) to std::atomic and removed the
Batcher::MarkHadErrors() utility method.
[1]
https://kudu.apache.org/cpp-client-api/classkudu_1_1client_1_1KuduSession.html
Change-Id: I69e1613d703bb689641186c4282fe8b3e821d323
Reviewed-on: http://gerrit.cloudera.org:8080/17673
Tested-by: Kudu Jenkins
Reviewed-by: Bankim Bhavsar <[email protected]>
---
M src/kudu/client/batcher.cc
M src/kudu/client/batcher.h
M src/kudu/client/client-test.cc
M src/kudu/client/session-internal.cc
M src/kudu/integration-tests/security-unknown-tsk-itest.cc
M src/kudu/integration-tests/txn_write_ops-itest.cc
6 files changed, 63 insertions(+), 71 deletions(-)
Approvals:
Kudu Jenkins: Verified
Bankim Bhavsar: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I69e1613d703bb689641186c4282fe8b3e821d323
Gerrit-Change-Number: 17673
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Bankim Bhavsar <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
