Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17155 )
Change subject: [thirdparty] Relativize thirdpary to make it relocatable ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/17155/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17155/1//COMMIT_MSG@9 PS1, Line 9: This patch adjusts the thirdparty build to relativize various : symbolic links making it relocatable within the same machine. I'm curious: did you verify it works as expected, i.e. building Kudu (not third-party itself) from scratch once a third-party is relocated when NO_REBUILD_THIRDPARTY env variable isn't set? There might be hard-coded absolute paths in the components already built in thirdparty, and it would be great to make sure it works as expected once the thirdparty is moved to somewhere else and pointed to by a symbolink itself (e.g. something like $KUDU_ROOT/thirdparty --> /opt/kudu/thirdparty) http://gerrit.cloudera.org:8080/#/c/17155/1/thirdparty/build-thirdparty.sh File thirdparty/build-thirdparty.sh: http://gerrit.cloudera.org:8080/#/c/17155/1/thirdparty/build-thirdparty.sh@277 PS1, Line 277: HIVE_SOURCE_REL Missed '$' symbols to make it a shell variable; should be $HIVE_SOURCE_REL I guess? -- To view, visit http://gerrit.cloudera.org:8080/17155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I011892e85d6f514cde165e0a46d77017a9ff50d1 Gerrit-Change-Number: 17155 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 13 Jul 2021 21:19:59 +0000 Gerrit-HasComments: Yes
