Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17680 )
Change subject: [common] extra test PartitionSchema and a small clean-up ...................................................................... [common] extra test PartitionSchema and a small clean-up While working on adding support for custom hash bucket schemas in range partitions for the Kudu C++ client, I found that a test scenario for custom range partitions with non-existent table-wide hash bucket schema was missing. This patch adds a simple one to cover such a case. In addition, I updated the code in partition.cc to use std::move semantics in PartitionSchema::GenerateHashPartitions() and other related methods. I also did other style-related changes. Change-Id: I66ff63488f34173e2f7f48db5aae73b2a612be8c Reviewed-on: http://gerrit.cloudera.org:8080/17680 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Andrew Wong <[email protected]> --- M src/kudu/common/partition-test.cc M src/kudu/common/partition.cc M src/kudu/common/partition.h 3 files changed, 337 insertions(+), 203 deletions(-) Approvals: Alexey Serbin: Verified Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I66ff63488f34173e2f7f48db5aae73b2a612be8c Gerrit-Change-Number: 17680 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241)
