Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17708 )
Change subject: [tools] --scan_batch_size for 'table scan' and 'perf table_scan' ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/17708/1/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/17708/1/src/kudu/tools/table_scanner.cc@606 PS1, Line 606: = > What does scan_batch_size of 0 mean? It means the first batch in the scan response will be without any data. It's documented in the client's API: https://github.com/apache/kudu/blob/5e895c642d28a1c5e3ee0845bb0775fe2e106d29/src/kudu/client/client.h#L2813-L2819 I added a comment to clarify on this. http://gerrit.cloudera.org:8080/#/c/17708/1/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/17708/1/src/kudu/tools/tool_action_table.cc@118 PS1, Line 118: The size for scan results batches, in bytes. A negative value " : "(e.g., -1) means the server-side default is used. > Nit: As a user I'm curious to know what's the default server-side scan batc Yep, as far as I can see, we don't provide a means to peek at that if using client API. It's a good idea to point to the corresponding server-side flag. Done. -- To view, visit http://gerrit.cloudera.org:8080/17708 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4fd5962eeda1d1d7921c6b70521f2d611ee1f3c7 Gerrit-Change-Number: 17708 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 21 Jul 2021 19:32:34 +0000 Gerrit-HasComments: Yes
