Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17704 )
Change subject: [common] 'client_schema' isn't needed in PartitionSchema::FromPB() ...................................................................... [common] 'client_schema' isn't needed in PartitionSchema::FromPB() This patch removes unnecessary 'client_schema' parameter introduced for PartitionSchema::FromPB() recently, also removing the overloaded variant of the PartitionSchema::FromPB() method as well. As far as I can see, neither ApplyAlterPartitioningSteps() nor CreateTable() methods of the CatalogManager class needs to pass client schema to PartitionSchema::FromPB(), and the tablet schema is a must in both places anyway because column identifiers are required there. Moreover, passing the client schema would only make the decoding slower because of the logic to loop over columns while building projection mapping in RowOperationsPBDecoder::DecodeOperations(). This is a follow-up to 2dda869456659a36247eb89f5b9e5e3837e5f8a3. Change-Id: Iff5697bc51046052da13c758d79d8c659bc90711 Reviewed-on: http://gerrit.cloudera.org:8080/17704 Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong <[email protected]> --- M src/kudu/common/partition.cc M src/kudu/common/partition.h M src/kudu/common/schema.cc M src/kudu/master/catalog_manager.cc 4 files changed, 8 insertions(+), 19 deletions(-) Approvals: Kudu Jenkins: Verified Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iff5697bc51046052da13c758d79d8c659bc90711 Gerrit-Change-Number: 17704 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]>
