Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17740 )
Change subject: [util] introduce comparison operators for Slice ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/17740/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17740/1//COMMIT_MSG@7 PS1, Line 7: common > nit: util? Done http://gerrit.cloudera.org:8080/#/c/17740/1//COMMIT_MSG@10 PS1, Line 10: In my opinion, that improves readability of the code. > Agreed. Thanks for this cleanup! Thank you for review! http://gerrit.cloudera.org:8080/#/c/17740/1/src/kudu/cfile/cfile_util.cc File src/kudu/cfile/cfile_util.cc: http://gerrit.cloudera.org:8080/#/c/17740/1/src/kudu/cfile/cfile_util.cc@144 PS1, Line 144: DCHECK(left <= *right); > nit: DCHECK_LE? Done http://gerrit.cloudera.org:8080/#/c/17740/1/src/kudu/tablet/rowset_info.cc File src/kudu/tablet/rowset_info.cc: http://gerrit.cloudera.org:8080/#/c/17740/1/src/kudu/tablet/rowset_info.cc@116 PS1, Line 116: DCHECK(min <= max); : DCHECK(imin <= imax); : DCHECK(min <= imin); : DCHECK(imax <= max); > nit: does DCHECK_LE work on the slices directly? Done -- To view, visit http://gerrit.cloudera.org:8080/17740 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I995803246fb3c21d8fe043b882fc93a87d9c2619 Gerrit-Change-Number: 17740 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Fri, 30 Jul 2021 04:10:14 +0000 Gerrit-HasComments: Yes
