Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17738 )
Change subject: [docker] KUDU-3307: allow using multiple directories ...................................................................... Patch Set 2: (2 comments) Thanks for taking this up, Andrew. Change looks good, only minor comments. http://gerrit.cloudera.org:8080/#/c/17738/2/docker/kudu-entrypoint.sh File docker/kudu-entrypoint.sh: http://gerrit.cloudera.org:8080/#/c/17738/2/docker/kudu-entrypoint.sh@42 PS2, Line 42: Defines the root directory to use. Subdirectories are added depending on whether a " : echo " Kudu master or a Kudu tablet server is being deployed. Ignored if the FS_WAL_DIR " : echo " environment variable is set." Nit: Might be worth adding a note about deprecating this variable. http://gerrit.cloudera.org:8080/#/c/17738/2/docker/kudu-entrypoint.sh@52 PS2, Line 52: to Nit: extra "to" -- To view, visit http://gerrit.cloudera.org:8080/17738 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20e5f75c1f1f8280dca60de75255a4a948e44be1 Gerrit-Change-Number: 17738 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 30 Jul 2021 16:54:25 +0000 Gerrit-HasComments: Yes
