Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17739 )
Change subject: [helm] fix usage of multiple directories ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17739/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17739/1//COMMIT_MSG@22 PS1, Line 22: I0730 00:36:07.404302 1 tablet_server_runner.cc:78] Ta > Just to be sure you modified storage.server.count in values.yaml to 5 while Yeah, updated the commit message to mention that. http://gerrit.cloudera.org:8080/#/c/17739/1/kubernetes/helm/kudu/templates/_helmutils.tpl File kubernetes/helm/kudu/templates/_helmutils.tpl: http://gerrit.cloudera.org:8080/#/c/17739/1/kubernetes/helm/kudu/templates/_helmutils.tpl@78 PS1, Line 78: {{range $index := untilStep 1 $num_dirs 1 -}}{{if ne $index 1}},{{end}}/mnt/disk{{ $index }}{{end}} > If storage.master.count happens to be 1 then the docker entry point script The logic here works since it leaves the field empty, and so the entrypoint should fall back on using the WAL directory. That said, I did find an issue with the entrypoint, fixed in the other patch. -- To view, visit http://gerrit.cloudera.org:8080/17739 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I583dff69c809e0851052c98267740a3e70c60efa Gerrit-Change-Number: 17739 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 30 Jul 2021 18:11:19 +0000 Gerrit-HasComments: Yes