Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17643 )
Change subject: [pruning] KUDU-2671: Pruning compatible with custom hash schemas. ...................................................................... Patch Set 9: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/17643/6/src/kudu/common/partition_pruner-test.cc File src/kudu/common/partition_pruner-test.cc: http://gerrit.cloudera.org:8080/#/c/17643/6/src/kudu/common/partition_pruner-test.cc@1491 PS6, Line 1491: ColumnPredicate::InList(schema.column(2), &C_values) }, > Yep, as shown by TestHashSchemasPerRangePruning where the range schema only Thank you for adding these scenarios! I apologize for not being crystal clear: I meant to see a test scenario with the following ranges for the range-partion part of the PK (assuming the upper range is exclusive): [0, 1), [1, 2), [2, 3) for INT range key and ['a', 'b'), ['b', 'c'), ['c', 'd') for STRING range key Do we have a coverage for such an edge case already? -- To view, visit http://gerrit.cloudera.org:8080/17643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05c37495430f61a2c6f6012c72251138aee465b7 Gerrit-Change-Number: 17643 Gerrit-PatchSet: 9 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 04 Aug 2021 00:49:17 +0000 Gerrit-HasComments: Yes
