Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17753 )
Change subject: [common] Update PartitionSchema::operator==() ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17753/1/src/kudu/common/partition.h File src/kudu/common/partition.h: http://gerrit.cloudera.org:8080/#/c/17753/1/src/kudu/common/partition.h@279 PS1, Line 279: static bool EqualHashBucketSchemas(const HashBucketSchemas& lhs_hb_schemas, : const HashBucketSchemas& rhs_hb_schemas); Is it possible to replace this static method with corresponding operator==() ? I mean to have something like the following instead: https://github.com/apache/kudu/blob/bca9d73f90d02209e67615c140cd9c5311a6d8fb/src/kudu/common/rowblock.h#L188-L189 -- To view, visit http://gerrit.cloudera.org:8080/17753 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09c626ecdcbe7c0465e6483d6a23369fb7194bfb Gerrit-Change-Number: 17753 Gerrit-PatchSet: 1 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 05 Aug 2021 00:22:18 +0000 Gerrit-HasComments: Yes
