Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17763 )
Change subject: [consensus] remove ForTests suffix from WaitUntilLeader ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/17763/1/src/kudu/consensus/raft_consensus.h File src/kudu/consensus/raft_consensus.h: http://gerrit.cloudera.org:8080/#/c/17763/1/src/kudu/consensus/raft_consensus.h@188 PS1, Line 188: Status WaitUntilLeader(const MonoDelta& timeout) nit: does it make sense to add WARN_UNUSED_RESULT attribute? http://gerrit.cloudera.org:8080/#/c/17763/1/src/kudu/consensus/raft_consensus_quorum-test.cc File src/kudu/consensus/raft_consensus_quorum-test.cc: http://gerrit.cloudera.org:8080/#/c/17763/1/src/kudu/consensus/raft_consensus_quorum-test.cc@905 PS1, Line 905: WaitUntilLeader(new_leader.get()); Is it possible to replace this with ASSERT_OK(new_leader->WaitUntilLeader(MonoDelta::FromSeconds(15)); and remove the WaitUntilLeaderForTest() local function? -- To view, visit http://gerrit.cloudera.org:8080/17763 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f5d61a59651c3a5f11e317a77c0344f5dd3e707 Gerrit-Change-Number: 17763 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 10 Aug 2021 01:07:23 +0000 Gerrit-HasComments: Yes
