Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17732 )
Change subject: [java] KUDU-1921 Add ability to require authn/encryption to Java client ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/17732/8/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: http://gerrit.cloudera.org:8080/#/c/17732/8/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@2735 PS8, Line 2735: // Only connects to remote servers that support encryption, fails : // otherwise. It can connect to insecure servers only locally. : REQUIRED_REMOTE, : // Only connects to any server, including on the loopback interface, : // that support encryption, fails otherwise. : REQUIRED, > nit: consider renaming these as well per suggestion at https://gerrit.cloud Done http://gerrit.cloudera.org:8080/#/c/17732/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java: http://gerrit.cloudera.org:8080/#/c/17732/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@574 PS8, Line 574: > While you are working on this, do you mind adding one extra test scenario t Sure, added it. -- To view, visit http://gerrit.cloudera.org:8080/17732 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic951b2090a4933eca70dc53b6f93cdcff5a74929 Gerrit-Change-Number: 17732 Gerrit-PatchSet: 9 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 10 Aug 2021 14:18:05 +0000 Gerrit-HasComments: Yes
