Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17733 )
Change subject: [python] KUDU-1921 Add ability to require auth/encryption ...................................................................... Patch Set 9: Code-Review+2 (1 comment) > > Patch Set 8: Code-Review+1 > > > > Looks good to me overall. > > > > Is it possible to add a small test scenario to cover the newly > introduced flags, maybe just for non-kerberized case? It seems > there is mini-cluster test scaffolding in python/kudu/tests/common.py. > > Added some tests (which was a very good idea indeed, had to fix the > code to). Thank you for adding these tests! LGTM, just a request to add one small comment for posterity. http://gerrit.cloudera.org:8080/#/c/17733/9/python/kudu/tests/test_client.py File python/kudu/tests/test_client.py: http://gerrit.cloudera.org:8080/#/c/17733/9/python/kudu/tests/test_client.py@509 PS9, Line 509: client = kudu.connect(self.master_hosts, self.master_ports, : require_authentication=True) nit: could you add a comment explaining why an exception is expected in this case (I guess the client is missing kerberos creds)? -- To view, visit http://gerrit.cloudera.org:8080/17733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10173145611ad2991c0a1b173ecadc7141ae6f5e Gerrit-Change-Number: 17733 Gerrit-PatchSet: 9 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 17 Aug 2021 18:28:28 +0000 Gerrit-HasComments: Yes
