Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17787 )
Change subject: [fuzz-itest] add WAL GCs ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/17787/4/src/kudu/consensus/log.cc File src/kudu/consensus/log.cc: http://gerrit.cloudera.org:8080/#/c/17787/4/src/kudu/consensus/log.cc@146 PS4, Line 146: og_segment_size_bytes_for_tests > For test only flags we should make them hidden. >From util/flag_tags.h // - "unsafe": // These flags are for internal use only (e.g. testing), and changing // them away from the defaults may result in arbitrarily bad things // happening. These flags are automatically excluded from user-facing // documentation even if they are not also marked 'hidden'. // // Users must pass --unlock_unsafe_flags to use any of these // flags. -- To view, visit http://gerrit.cloudera.org:8080/17787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabd9fe33f9fa21f62b513d7607bf62b6fce6bb59 Gerrit-Change-Number: 17787 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 19 Aug 2021 02:03:32 +0000 Gerrit-HasComments: Yes
