Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17797 )
Change subject: [tablet] small clean-up ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/17797/2/src/kudu/tablet/tablet_metadata.cc File src/kudu/tablet/tablet_metadata.cc: http://gerrit.cloudera.org:8080/#/c/17797/2/src/kudu/tablet/tablet_metadata.cc@308 PS2, Line 308: schema_(new Schema(schema)), Since schema_ is a unique_ptr for readability it'd be good to use std::make_unique<Schema>(schema) instead. -- To view, visit http://gerrit.cloudera.org:8080/17797 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ebe39d483605840b22e6ec2d9eb66b1f4fe9b07 Gerrit-Change-Number: 17797 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 20 Aug 2021 17:08:25 +0000 Gerrit-HasComments: Yes
